Re: [RFC: PATCH] OMAP: hwmod: New API to modify the autoidle bits of sysconfig register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 31 Aug 2010 10:53:36 +0530, kishon <a0393678@xxxxxx> wrote:
>      Though driver shouldn't be using hwmod directly, there is no 
> corresponding API in omap_device to do the same. So we are planning to
>      store the omap_hwmod structure in platform_data during 
> arch_initcall (in the callback to omap_hwmod_for_each_by_class). So 
> whenever the
>      AUTOIDLE bits need to be reset or set, we pass the stored 
> omap_hwmod structure to this API. Currently, the functions that needs 
> AUTOIDLE
>      bit to be modified (omap_st_on, omap_st_off) resides in plat-omap.

couldn't your API instead be something like:

int omap_hwmod_set_autoidle(struct device *dev, u8 autoidle)
{
	struct omap_hwmod *oh = dev_to_hwmod(dev);

	if (!oh)
		return -ENODEV;
	[...]

	return 0;
}

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux