> -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx] > Sent: Thursday, August 19, 2010 11:33 AM > To: Munegowda, Keshava > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Gadiyar, Anand > Subject: Re: [PATCH 5/6] usb: ohci: don't hard-code TLL channel count > > Hi, > > On Wed, Aug 18, 2010 at 04:55:45AM +0200, ext Keshava Munegowda wrote: > >@@ -245,7 +245,8 @@ static unsigned ohci_omap3_fslsmode(enum > > } > > } > > > >-static void ohci_omap3_tll_config(struct ohci_hcd_omap3 *omap) > >+static void ohci_omap3_tll_config(struct ohci_hcd_omap3 *omap, > >+ u8 tll_channel_count) > > { > > u32 reg; > > int i; > >@@ -263,7 +264,7 @@ static void ohci_omap3_tll_config(struct > > * REVISIT: Only the 3-pin and 4-pin PHY modes have > > * actually been tested. > > */ > >- for (i = 0; i < OMAP_TLL_CHANNEL_COUNT; i++) { > >+ for (i = 0; i < tll_channel_count; i++) { > > > > /* Enable only those channels that are actually used */ > > if (omap->port_mode[i] == OMAP_OHCI_PORT_MODE_UNUSED) > >@@ -422,7 +423,7 @@ static int omap3_start_ohci(struct ohci_ > > ohci_omap_writel(omap->uhh_base, OMAP_UHH_HOSTCONFIG, reg); > > dev_dbg(omap->dev, "UHH setup done, uhh_hostconfig=%x\n", reg); > > > >- ohci_omap3_tll_config(omap); > >+ ohci_omap3_tll_config(omap, OMAP_TLL_CHANNEL_COUNT); > > it's still hardcoded, are you planning to change this in any way ? > Otherwise I don't see the point for this patch. > > -- > balbi The function ohci_omap3_tll_config will be used with different tll channel count in case of OMAP4 support soon, hence this change is required. We have removed only the hardcoded values used by this function. Keshava Munegowda > DefectiveByDesign.org -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
