Re: [PM-SR][PATCH 01/12] omap3: voltage: cleanup pr_xxxx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 06, 2010 at 08:10:44AM -0500, Nishanth Menon wrote:

> a) when the strings are split up when they go multiple lines:
> E.g.:
> 	"abcd "
> 	"efg"
> print comes out abcd efg

That's generally considered bad practice for precisely this reason.

> c) time required:
> $ time git grep "DEBUG option not enabled" .
> arch/arm/mach-omap2/smartreflex.c:              pr_notice("DEBUG
> option not enabled!\n  \
> arch/arm/mach-omap2/voltage.c:          pr_notice("DEBUG option not
> enabled!\n  \

> real	1m34.722s
> user	0m0.440s
> sys	0m1.820s

> Vs cscope or ctags where it is rather instantaneous if you know the
> function name..

Interesting, I see better performance than that, especially hot cache,
and of course an educated guess as to where to look helps greatly.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux