RE: [PM-SR][PATCH 01/12] omap3: voltage: cleanup pr_xxxx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




>>-----Original Message-----
>>From: Menon, Nishanth
>>Sent: Friday, August 06, 2010 3:54 AM
>>To: linux-omap
>>Cc: Menon, Nishanth; Kevin Hilman; Gopinath, Thara
>>Subject: [PM-SR][PATCH 01/12] omap3: voltage: cleanup pr_xxxx
>>
>>Few more pr_xxxx need cleanup for printing the function name and
>>not using multiline prints when c allows us to do "".
>>
>>Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
>>Cc: Thara Gopinath <thara@xxxxxx>
>>
>>Signed-off-by: Nishanth Menon <nm@xxxxxx>
>>---
>> arch/arm/mach-omap2/voltage.c |    7 ++++---
>> 1 files changed, 4 insertions(+), 3 deletions(-)
>>
>>diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
>>index 148e4d4..3431fa3 100644
>>--- a/arch/arm/mach-omap2/voltage.c
>>+++ b/arch/arm/mach-omap2/voltage.c
>>@@ -253,8 +253,9 @@ static int vp_debug_set(void *data, u64 val)
>> 		u32 *option = data;
>> 		*option = val;
>> 	} else {
>>-		pr_notice("DEBUG option not enabled!\n	\
>>-			echo 1 > pm_debug/enable_sr_vp_debug - to enable\n");
>>+		pr_notice("%s: DEBUG option not enabled! "
>>+			"echo 1 > pm_debug/enable_sr_vp_debug - to enable\n",
>>+			__func__);
>> 	}

I do not think this is needed as these fns get called only from user space.

Regards
Thara

>> 	return 0;
>> }
>>@@ -265,7 +266,7 @@ static int vp_volt_debug_get(void *data, u64 *val)
>> 	u8 vsel;
>>
>> 	vsel = voltage_read_reg(info->vp_offs.voltage_reg);
>>-	pr_notice("curr_vsel = %x\n", vsel);
>>+	pr_notice("%s: curr_vsel = %x\n", __func__, vsel);
>> 	*val = vsel * 12500 + 600000;
>>
>> 	return 0;
>>--
>>1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux