Kevin Hilman wrote: > Hemant Pedanekar <hemantp@xxxxxx> writes: > >> This patch adds minimal support for TI816X EVM to enable kernel boot. >> >> Signed-off-by: Hemant Pedanekar <hemantp@xxxxxx> > > [...] >> +#include <linux/kernel.h> >> +#include <linux/init.h> >> +#include <linux/device.h> >> +#include <linux/spi/spi.h> >> +#include <linux/spi/flash.h> >> +#include <linux/platform_device.h> >> +#include <linux/gpio.h> >> +#include <linux/i2c.h> >> +#include <linux/i2c/pcf857x.h> >> +#include <linux/i2c/at24.h> >> +#include <linux/mtd/mtd.h> >> +#include <linux/mtd/nand.h> >> +#include <linux/mtd/partitions.h> >> +#include <linux/mtd/physmap.h> >> +#include <linux/phy.h> > > Looks like most of these headers are not needed for this minimal > support. It's preferred to have a minimal set of headers here and add > them later as needed when the devices are added. > >> +#include <mach/hardware.h> >> +#include <asm/mach-types.h> >> +#include <asm/mach/arch.h> >> +#include <asm/mach/map.h> >> + >> +#include <plat/irqs.h> >> +#include <plat/mux.h> >> +#include <plat/board.h> >> +#include <plat/common.h> >> +#include <plat/timer-gp.h> >> + >> +static void __init ti8168_evm_init_irq(void) >> +{ >> + omap2_gp_clockevent_set_gptimer(2); > > Just curious why GPT2 is used here. > >> + omap2_init_common_hw(NULL, NULL); >> + omap_init_irq(); >> +} > > Kevin Currently, first timer is reserved on TI816X. I will cleanup the includes and add timer comment. Thanks - Hemant -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html