>>-----Original Message----- >>From: Menon, Nishanth >>Sent: Friday, August 06, 2010 3:54 AM >>To: linux-omap >>Cc: Menon, Nishanth; Kevin Hilman; Gopinath, Thara >>Subject: [PM-SR][PATCH 12/12] omap3: sr: class3: make class3_data static >> >>we dont expose the structure to the world, so this should be static >>however, since sr core does not take a copy of the same, we cant make >>it __init data. >> >>fixes sparse warning: >>arch/arm/mach-omap2/smartreflex-class3.c:50:36: warning: symbol 'class3_data' was not declared. >>Should it be static? >> >>Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> >>Cc: Thara Gopinath <thara@xxxxxx> >> >>Signed-off-by: Nishanth Menon <nm@xxxxxx> >>--- >> arch/arm/mach-omap2/smartreflex-class3.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >>diff --git a/arch/arm/mach-omap2/smartreflex-class3.c b/arch/arm/mach-omap2/smartreflex-class3.c >>index f3b766f..530b2f0 100644 >>--- a/arch/arm/mach-omap2/smartreflex-class3.c >>+++ b/arch/arm/mach-omap2/smartreflex-class3.c >>@@ -47,7 +47,7 @@ static int sr_class3_configure(int id) >> } >> >> /* SR class3 structure */ >>-struct omap_smartreflex_class_data class3_data = { >>+static struct omap_smartreflex_class_data class3_data = { >> .enable = sr_class3_enable, >> .disable = sr_class3_disable, >> .configure = sr_class3_configure, Taken in Regards Thara >>-- >>1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html