RE: [PM-SR][PATCH 05/12] omap3: sr: device: check for dev_attr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




>>-----Original Message-----
>>From: Menon, Nishanth
>>Sent: Friday, August 06, 2010 3:54 AM
>>To: linux-omap
>>Cc: Menon, Nishanth; Kevin Hilman; Gopinath, Thara
>>Subject: [PM-SR][PATCH 05/12] omap3: sr: device: check for dev_attr
>>
>>In the unlikely case that hwmod database is messed up, dont crash
>>report error and attempt to recover.
>>
>>Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
>>Cc: Thara Gopinath <thara@xxxxxx>
>>
>>Signed-off-by: Nishanth Menon <nm@xxxxxx>
>>---
>> arch/arm/mach-omap2/sr_device.c |    6 ++++++
>> 1 files changed, 6 insertions(+), 0 deletions(-)
>>
>>diff --git a/arch/arm/mach-omap2/sr_device.c b/arch/arm/mach-omap2/sr_device.c
>>index 7d13704..6f70da6 100644
>>--- a/arch/arm/mach-omap2/sr_device.c
>>+++ b/arch/arm/mach-omap2/sr_device.c
>>@@ -130,6 +130,12 @@ static int sr_dev_init(struct omap_hwmod *oh, void *user)
>> 	}
>>
>> 	sr_dev_data = (struct omap_sr_dev_data *)oh->dev_attr;
>>+	if (unlikely(!sr_dev_data)) {
>>+		pr_err("%s: Bad oh->dev_attr!\n", __func__);
>>+		kfree(sr_data);
>>+		return -EINVAL;
>>+	}

Taken in after modifications as per the reply for patch 06/12

Regards
Thara
>>+
>> 	/*
>> 	 * OMAP3430 ES3.1 chips by default come with Efuse burnt
>> 	 * with parameters required for full functionality of
>>--
>>1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux