RE: [PATCH] omap4: fb: Adds missing display update call when panning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Janorkar, Mayuresh
> Sent: Thursday, July 15, 2010 6:07 PM
> To: tomi.valkeinen@xxxxxxxxx
> Cc: linux-omap@xxxxxxxxxxxxxxx; Diaz Prado, Gustavo; Janorkar, Mayuresh
> Subject: [PATCH] omap4: fb: Adds missing display update call when panning
> 
> From: Gustavo Diaz Prado <x0083741@xxxxxx>
> 
> Adds the missing display update call when panning, this
> is needed for the DSI panel when the auto-update feature is
> not enabled.
> 
> Signed-off-by: Gustavo Diaz Prado <x0083741@xxxxxx>
> Signed-off-by: Mayuresh Janorkar <mayur@xxxxxx>
> ---
>  drivers/video/omap2/omapfb/omapfb-main.c |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c
> b/drivers/video/omap2/omapfb/omapfb-main.c
> index 4abb1d1..12d5382 100644
> --- a/drivers/video/omap2/omapfb/omapfb-main.c
> +++ b/drivers/video/omap2/omapfb/omapfb-main.c
> @@ -1068,7 +1068,8 @@ static int omapfb_pan_display(struct
> fb_var_screeninfo *var,
>  {
>  	struct omapfb_info *ofbi = FB2OFB(fbi);
>  	struct fb_var_screeninfo new_var;
> -	int r;
> +	int r = 0;
> +	struct omap_dss_device *display = fb2display(fbi);
> 
>  	DBG("pan_display(%d)\n", FB2OFB(fbi)->id);
> 
> @@ -1086,6 +1087,11 @@ static int omapfb_pan_display(struct
> fb_var_screeninfo *var,
> 
>  	r = omapfb_apply_changes(fbi, 0);
> 
> +	if (display && display->driver->update &&
> +		display->driver->get_update_mode(display)
> +			== OMAP_DSS_UPDATE_MANUAL)
If the display dereference is checked, there is no need to check the base
pointer (display), right ?
> +		display->driver->update(display, 0, 0, var->xres, var->yres);
> +
>  	omapfb_put_mem_region(ofbi->region);
> 
>  	return r;
> --
> 1.5.4.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux