Artem Bityutskiy had written, on 07/09/2010 10:44 AM, the following:
On Fri, 2010-07-09 at 20:35 +0530, Gopinath, Thara wrote:
-----Original Message-----
From: Artem Bityutskiy [mailto:dedekind1@xxxxxxxxx]
Sent: Friday, July 09, 2010 6:50 PM
To: linux-omap@xxxxxxxxxxxxxxx
Cc: Menon, Nishanth; Kevin Hilman; Gopinath, Thara; Peter p2 De Schrijver
Subject: [PATCH 2/2] omap3: sr: improve errors handling
From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
Do not forget to check the 'platform_device_add_data()' error code
in 'omap_device_build_ss()'.
Hello Artem,
Can we have a better subject and description. The subject esp has got
nothing to do with the fix.
Hmm, I do not see why you think so. I think the subject is fine - the
patch improves error handling in the SR code. Then description says how
exactly it improves it - it makes the code to not forget to check the
return code, and it tells in which function and which return code.
So the logic is:
1. The subject line is a short description which gives the idea what the
commit is about. So, my subject line says:
1.1. It is about omap3 (which is true)
1.2. It is about sr (which is true)
I think Thara's contention is that this is omap_device related- yeah SR
is one of the users of omap_device, but there are much more folks using
omap_device in l-o today.
1.3. It improves error handling (which is also true)
So the subject line is descriptive enough. It does not have to provide
all glory details.
Then the description provides the details.
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
