>>-----Original Message----- >>From: Artem Bityutskiy [mailto:dedekind1@xxxxxxxxx] >>Sent: Friday, July 09, 2010 6:50 PM >>To: linux-omap@xxxxxxxxxxxxxxx >>Cc: Menon, Nishanth; Kevin Hilman; Gopinath, Thara; Peter p2 De Schrijver >>Subject: [PATCH 2/2] omap3: sr: improve errors handling >> >>From: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx> >> >>Do not forget to check the 'platform_device_add_data()' error code >>in 'omap_device_build_ss()'. Hello Artem, Can we have a better subject and description. The subject esp has got nothing to do with the fix. Regards Thara >> >>Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx> >>--- >> arch/arm/plat-omap/omap_device.c | 4 +++- >> 1 files changed, 3 insertions(+), 1 deletions(-) >> >>diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c >>index f2bd2e2..e8da192 100644 >>--- a/arch/arm/plat-omap/omap_device.c >>+++ b/arch/arm/plat-omap/omap_device.c >>@@ -414,7 +414,9 @@ struct omap_device *omap_device_build_ss(const char *pdev_name, int pdev_id, >> od->pdev.num_resources = res_count; >> od->pdev.resource = res; >> >>- platform_device_add_data(&od->pdev, pdata, pdata_len); >>+ ret = platform_device_add_data(&od->pdev, pdata, pdata_len); >>+ if (ret) >>+ goto odbs_exit4; >> >> od->pm_lats = pm_lats; >> od->pm_lats_cnt = pm_lats_cnt; >>-- >>1.7.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
