Re: [RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset gpio handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 29 jun 2010, om 22:32 heeft Sergio Aguirre het volgende geschreven:

> Following commit missed to remove this:
> 
>  commit 044d32ffbcb4a1d400088e3575508f46c0a9face
>  Author: Koen Kooi <koen.kooi@xxxxxxxxx>
>  Date:   Thu Apr 22 10:23:42 2010 +0200
> 
>      board-omap3-beagle: add DSS2 support
> 
> Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
> Cc: Koen Kooi <koen.kooi@xxxxxxxxx>

Looks good to me:

Acked-by: Koen Kooi <koen.kooi@xxxxxxxxx>

As a side note, the beagleboard xM uses a different pin for that.

regards,

Koen


> ---
> arch/arm/mach-omap2/board-omap3beagle.c |    7 ++-----
> 1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 7b95cc1..867a4ad 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -169,6 +169,8 @@ static void __init beagle_display_init(void)
> {
> 	int r;
> 
> +	omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT);
> +
> 	r = gpio_request(beagle_dvi_device.reset_gpio, "DVI reset");
> 	if (r < 0) {
> 		printk(KERN_ERR "Unable to get DVI reset GPIO\n");
> @@ -491,11 +493,6 @@ static void __init omap3_beagle_init(void)
> 			ARRAY_SIZE(omap3_beagle_devices));
> 	omap_serial_init();
> 
> -	omap_mux_init_gpio(170, OMAP_PIN_INPUT);
> -	gpio_request(170, "DVI_nPD");
> -	/* REVISIT leave DVI powered down until it's needed ... */
> -	gpio_direction_output(170, true);
> -
> 	usb_musb_init(&musb_board_data);
> 	usb_ehci_init(&ehci_pdata);
> 	omap3beagle_flash_init();
> -- 
> 1.6.3.3
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux