Re: [RFC][PATCH] omap3: Unify omap2_set_globals_3[43,6x]x functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Mike Rapoport <mike@xxxxxxxxxxxxxx> [100630 08:20]:
> Sergio Aguirre wrote:
> >The only difference between them is the physical address of the
> >uart4 port, which is only present in 36xx chips.
> >
> >We don't really need to care about keeping these 2 functions, since
> >the decision to use uart4 is more cleanly done later when we do have
> >access to omap_revision variable.
> >
> >Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx>
> >---
> > arch/arm/mach-omap2/board-3430sdp.c        |    2 +-
> > arch/arm/mach-omap2/board-3630sdp.c        |    2 +-
> > arch/arm/mach-omap2/board-am3517evm.c      |    2 +-
> > arch/arm/mach-omap2/board-cm-t35.c         |    2 +-
> > arch/arm/mach-omap2/board-devkit8000.c     |    2 +-
> > arch/arm/mach-omap2/board-igep0020.c       |    2 +-
> > arch/arm/mach-omap2/board-ldp.c            |    2 +-
> > arch/arm/mach-omap2/board-omap3beagle.c    |    2 +-
> > arch/arm/mach-omap2/board-omap3evm.c       |    2 +-
> > arch/arm/mach-omap2/board-omap3pandora.c   |    2 +-
> > arch/arm/mach-omap2/board-omap3stalker.c   |    2 +-
> > arch/arm/mach-omap2/board-omap3touchbook.c |    2 +-
> > arch/arm/mach-omap2/board-overo.c          |    2 +-
> > arch/arm/mach-omap2/board-rx51.c           |    2 +-
> > arch/arm/mach-omap2/board-zoom2.c          |    2 +-
> > arch/arm/mach-omap2/board-zoom3.c          |    2 +-
> > arch/arm/plat-omap/common.c                |   10 ++--------
> > arch/arm/plat-omap/include/plat/common.h   |    3 +--
> > 18 files changed, 19 insertions(+), 26 deletions(-)
> >
> >diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> >index dd9c031..4961f3b 100644
> >--- a/arch/arm/mach-omap2/board-3430sdp.c
> >+++ b/arch/arm/mach-omap2/board-3430sdp.c
> >@@ -805,7 +805,7 @@ static void __init omap_3430sdp_init(void)
> > static void __init omap_3430sdp_map_io(void)
> > {
> >-	omap2_set_globals_343x();
> >+	omap2_set_globals_3xxx();
> > 	omap34xx_map_common_io();
> > }
> 
> Maybe we should take it one step further and replace board_map_io
> functions with common omap3_map_io?

Could be done yeah. If special handling is needed, it can still
be done in the board-*.c files. Care to do a patch for that?

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux