On Thu, 2010-06-17 at 07:12 +0200, ext Nagarajan, Rajkumar wrote: > When switching between clocks, The new functional clock is > effective when the next vertical blanking interval occurs. > GOLCD bit has to be set for the new clock to take effect. Where did you encounter this problem? > Signed-off-by: Kishore Y <kishore.y@xxxxxx> > Signed-off-by: Mukund Mittal <mmittal@xxxxxx> > Signed-off-by: Rajkumar N <rajkumar.nagarajan@xxxxxx> > --- > drivers/video/omap2/dss/dpi.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/omap2/dss/dpi.c b/drivers/video/omap2/dss/dpi.c > index 960e977..5d778d6 100644 > --- a/drivers/video/omap2/dss/dpi.c > +++ b/drivers/video/omap2/dss/dpi.c > @@ -214,10 +214,15 @@ void omapdss_dpi_display_disable(struct omap_dss_device *dssdev) > > #ifdef CONFIG_OMAP2_DSS_USE_DSI_PLL > dss_select_dispc_clk_source(DSS_SRC_DSS1_ALWON_FCLK); > + dispc_go(OMAP_DSS_CHANNEL_LCD); I don't think GO does anything here, as the channel has already been disabled. > + while (dispc_go_busy(OMAP_DSS_CHANNEL_LCD)) > + ; Busy looping is not good. > dsi_pll_uninit(); > dss_clk_disable(DSS_CLK_FCK2); > #endif > > + dispc_enable_channel(OMAP_DSS_CHANNEL_LCD, 0); > + The channel has already been disabled above, in dssdev->manager->disable(dssdev->manager); Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
