RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Guruswamy, Senthilvadivu
> Sent: Tuesday, June 22, 2010 5:29 PM
> To: Guruswamy, Senthilvadivu; Hiremath, Vaibhav; Tomi Valkeinen
> Cc: linux-omap@xxxxxxxxxxxxxxx; linux-dev@xxxxxxxxxxxxxxx; tony@xxxxxxxxxxx
> Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3
> 
> 
> 
> > -----Original Message-----
> > From: Guruswamy, Senthilvadivu
> > Sent: Monday, June 21, 2010 2:52 PM
> > To: Hiremath, Vaibhav; Tomi Valkeinen
> > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-dev@xxxxxxxxxxxxxxx;
> > tony@xxxxxxxxxxx
> > Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB
> > depends on OMAP2,3
> >
> >
> >
> > > -----Original Message-----
> > > From: Hiremath, Vaibhav
> > > Sent: Monday, June 21, 2010 2:27 PM
> > > To: Tomi Valkeinen; Guruswamy, Senthilvadivu
> > > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-dev@xxxxxxxxxxxxxxx;
> > > tony@xxxxxxxxxxx
> > > Subject: RE: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB
> > > depends on OMAP2,3
> > >
> > > > -----Original Message-----
> > > > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx]
> > > > Sent: Monday, June 21, 2010 2:21 PM
> > > > To: Guruswamy, Senthilvadivu
> > > > Cc: linux-omap@xxxxxxxxxxxxxxx; linux-dev@xxxxxxxxxxxxxxx;
> > > tony@xxxxxxxxxxx;
> > > > Hiremath, Vaibhav
> > > > Subject: Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB
> > > depends on OMAP2,3
> > > >
> > > > On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy
> > > Senthilvadivu wrote:
> > > > > From: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> > > > >
> > > > > config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> > > > >
> > > > > Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> > > > > ---
> > > > >  drivers/video/omap2/Kconfig            |    4 ++++
> > > > >  drivers/video/omap2/omapfb/Kconfig     |    1 -
> > > > >  2 files changed,  4 insertions(+), 1 deletions(-)
> <snip>
> > > > The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
> > > > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
> > > >
> > > [Hiremath, Vaibhav] If you are doing something like this,
> > > then please do not forget to change V4L2 Display driver also.
> > [Senthil]  Yes, I would send a patch with a similar change in
> > media/video/omap/Kconfig also.
> [Senthil]  This V4L2 related patch would be along with the V4L2 change
> set, as it requires some work on the omap_vout.c also along with the kconfig
> change.
> 
[Hiremath, Vaibhav] I think we are creating confusion here, on Fbdev side it looks clean, but on V4L2 side you are still enabling VRFB. So if you try to enable V4L2 display driver then it automatically enabled VRFB.

I still feel changes in V4L2 driver should be part of this patch series to maintain consistency.

Thanks,
Vaibhav

> Regards,
> Senthil
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux