Re: [PATCH v3 2/3] OMAP: DSS2: OMAPFB: make VRFB depends on OMAP2,3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-06-17 at 14:45 +0200, ext Guruswamy Senthilvadivu wrote:
> From: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> 
> config VRFB should depend on ARCH_OMAP2 or ARCH_OMAP3.
> 
> Signed-off-by: Senthilvadivu Guruswamy <svadivu@xxxxxx>
> ---
>  drivers/video/omap2/Kconfig            |    4 ++++
>  drivers/video/omap2/omapfb/Kconfig     |    1 -
>  2 files changed,  4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/omap2/Kconfig b/drivers/video/omap2/Kconfig
> index d877c36..18bb835 100644
> --- a/drivers/video/omap2/Kconfig
> +++ b/drivers/video/omap2/Kconfig
> @@ -3,6 +3,10 @@ config OMAP2_VRAM
>  
>  config OMAP2_VRFB
>  	bool
> +	depends on ARCH_OMAP2 || ARCH_OMAP3
> +	default y if FB_OMAP2
> +	help
> +	  OMAP VRFB buffer support is efficient for rotation
>  
>  source "drivers/video/omap2/dss/Kconfig"
>  source "drivers/video/omap2/omapfb/Kconfig"
> diff --git a/drivers/video/omap2/omapfb/Kconfig b/drivers/video/omap2/omapfb/Kconfig
> index a3ed15c..f186c2b 100644
> --- a/drivers/video/omap2/omapfb/Kconfig
> +++ b/drivers/video/omap2/omapfb/Kconfig
> @@ -3,7 +3,6 @@ menuconfig FB_OMAP2
>          depends on FB && OMAP2_DSS
>  
>  	select OMAP2_VRAM
> -	select OMAP2_VRFB
>          select FB_CFB_FILLRECT
>          select FB_CFB_COPYAREA
>          select FB_CFB_IMAGEBLIT

This is second patch set marked as v3. Please update the version for
every patch set.

I think the config selection is now a bit confusing. I think it should
either be:

The omap2/Kconfig left as it is, and omapfb/Kconfig changed to:
select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3

or

Let the user select VRFB.

 Tomi


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux