Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Varadarajan, Charulatha" <charu@xxxxxx> writes:

[...]

>> 
>> So please, don't do that.
>> 
>> BTW, you didn't answer the first answer, do you really need that?
>> 
> It is used in save/restore context which would be called
> from sram_idle path.

Cleaning this up should be considered instead of keeping around the
bank count.

The save/restore should be done per-bank whenever the bank usage count
goes to zero (or changes from zero.)

If you don't want to address that cleanup in this series, add it to
the TODO list for the cleanups and use the current variable, but it's
value should be set when iterating over the number of hwmods as
suggested by Benoit.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux