> From: Nishanth Menon [mailto:nm@xxxxxx] > Sent: Monday, May 31, 2010 9:36 AM > To: Gadiyar, Anand > Cc: G, Manjunath Kondaiah; linux-omap@xxxxxxxxxxxxxxx; Tony Lindgren > Subject: Re: [PATCH] OMAP3630: Update ES1.1 silicon revision detection > > On 05/31/2010 03:50 PM, Gadiyar, Anand wrote: > > Manjunatha GK wrote: > >> This patch updates ES1.1 silicon revision ID for OMAP3630 > >> processor. The silicon revision can be read by reading hawkeye > >> and revision bits in IDCODE register. > >> > >> Tested on 3630sdp(with ES1.1 silicon) and Zoom3(with ES1.0) silicon. > >> > >> Signed-off-by: Manjunatha GK<manjugk@xxxxxx> > >> Cc: Nishanth Menon<nm@xxxxxx> > >> Cc: Tony Lindgren<tony@xxxxxxxxxxx> > > > > Ping? > > > > FWIW, tested on other OMAP3 ES1.1 boards too. > > > >> --- > >> arch/arm/mach-omap2/id.c | 20 ++++++++++++++++---- > >> arch/arm/plat-omap/include/plat/cpu.h | 3 +++ > >> 2 files changed, 19 insertions(+), 4 deletions(-) > >> > >> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c > >> index 37b8a1a..dd26092 100644 > >> --- a/arch/arm/mach-omap2/id.c > >> +++ b/arch/arm/mach-omap2/id.c > >> @@ -259,11 +259,20 @@ void __init omap3_check_revision(void) > >> omap_chip.oc |= CHIP_IS_OMAP3430ES3_1; > >> break; > >> case 0xb891: > >> - /* FALLTHROUGH */ > >> - default: > >> - /* Unknown default to latest silicon rev as default*/ > >> - omap_revision = OMAP3630_REV_ES1_0; > >> + /* Handle 36xx devices */ > >> omap_chip.oc |= CHIP_IS_OMAP3630ES1; > >> + > >> + switch(rev) { > >> + case 0: /* Take care of early samples */ > >> + omap_revision = OMAP3630_REV_ES1_0; > >> + break; > >> + case 1: > >> + /* Fall through */ > >> + default: > >> + /* Use the latest known revision as default */ > >> + omap_revision = OMAP3630_REV_ES1_1; > >> + omap_chip.oc |= CHIP_IS_OMAP3630ES1_1; > > just a late realization relooking at the code: omap_chip.oc is ES1 and > ES1_1? Just realized that the logic is really sane. Thanks anand for pointing out. Acked-by: Nishanth Menon <nm@xxxxxx> Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
