On Thu, May 27, 2010 at 6:54 PM, Sukumar Ghorai <s-ghorai@xxxxxx> wrote:
[...]
> -static unsigned gpmc_cs_map;
> +static unsigned int gpmc_cs_map; /* flag for cs which are initialized */
Tab should be after 'int', not before.
[...]
> @@ -456,13 +565,22 @@ EXPORT_SYMBOL(gpmc_prefetch_enable);
> /**
> * gpmc_prefetch_reset - disables and stops the prefetch engine
> */
> -void gpmc_prefetch_reset(void)
> +int gpmc_prefetch_reset(int cs)
> {
> + u32 config1;
> +
> + /* check if the same module/cs is trying to reset */
> + config1 = gpmc_read_reg(GPMC_PREFETCH_CONFIG1);
> + if (((config1 >> CS_NUM_SHIFT) & 0x7) != cs)
> + return -EINVAL;
> +
You really do not need this.
Prefetch has just one instance at a time and 'reset' will be call only
when driver has got access to prefetch (for either read or write
access), from the driver.
--
Regards,
Vimal Singh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
