On 5/21/2010 12:00 PM, Sergei Shtylyov wrote:
Hello.
Paul Walmsley wrote:
From: Benoit Cousson<b-cousson@xxxxxx>
The WARN is a little bit too verbose and is not providing
usefull information in that case.
Signed-off-by: Benoit Cousson<b-cousson@xxxxxx>
Signed-off-by: Paul Walmsley<paul@xxxxxxxxx>
[...]
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index a62920b..5d3a3ea 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -411,9 +411,9 @@ static int _init_main_clk(struct omap_hwmod *oh)
return 0;
c = omap_clk_get_by_name(oh->main_clk);
- WARN(!c, "omap_hwmod: %s: cannot clk_get main_clk %s\n",
- oh->name, oh->main_clk);
if (!c)
+ pr_warning("omap_hwmod: %s: cannot clk_get main_clk %s\n",
+ oh->name, oh->main_clk);
ret = -EINVAL;
Don't you need {} around the statements here?
You don't like the Python style for managing block? :-)
In that case, it is indeed better to have that.
I'll fix that one and the following ones.
Thanks,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
