On Thu, May 20, 2010 at 2:01 PM, Thomas Renninger <trenn@xxxxxxx> wrote: > Hi Mike, > > On Thursday 20 May 2010 08:42:21 pm Mike Chan wrote: >> v2: >> Rebased off of Thomas Renninger's patch for cgroups_cpuacct refactoring, > thanks. > A general comment: > I don't know much about the cgroup stuff. Perhaps Paul Menage or Balbir Singh can look and sign off on the API's? > I am also not sure how exactly power can be measured on this arch based on If you know how much time was spent at each frequency executing code, you can calculate how much power was consumed if the platform (with hooks) provide power numbers (in milliWatts) for the power at frequency X. I did some initial testing on Motorola Droid comparing to a power meter and I got within 2% variance. > frequency accounting (there also were some threads I was not aware of?) > A signed-off-by or reviewed-by from someone who is more involved in this omap > stuff would probably not that bad. > OMAP was the closest with mainline support I could provide an example how to use these hooks. I'm hoping for some blessing from some people on the linux-omap list for that. However can we possibly just stack the first two patches to get the API in? This will make it easier to fixup the omap hooks if they don't get in. -- Mike > Still I Iike this interface and I could imagine others hook into it as well, > for whatever has to be cpu cgroup accounted. > > My two cents..., > > Thomas > -- > To unsubscribe from this list: send the line "unsubscribe cpufreq" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
