> -----Original Message----- > From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx] > Sent: Friday, May 14, 2010 10:10 PM > To: G, Manjunath Kondaiah > Cc: linux-omap@xxxxxxxxxxxxxxx; Agarwal, Preshit; Tony > Lindgren; Turquette, Mike; V, Hemanth > Subject: Re: [PATCH v4] OMAP3: Registering sgx device and > it's platform data > > Manjunatha GK <manjugk@xxxxxx> writes: > > > The SGX powervr_device is registered with it's platform specific > > data to provide information about setting constraint through > > omap_pm_set_min_bus_tput. > > Now the patch content doesn't match the description as you no > longer call omap_pm_set_min_bus_tput()... > > > Signed-off-by: Preshit Agarwal <preshit.agarwal@xxxxxx> > > Signed-off-by: Manjunatha GK <manjugk@xxxxxx> > > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > > Cc: Mike Turquette <mturquette@xxxxxx> > > Cc: Hemanth V <hemanthv@xxxxxx> > > --- > > arch/arm/mach-omap2/devices.c | 21 > +++++++++++++++++++-- > > arch/arm/mach-omap2/include/mach/omap_sgxdef.h | 11 +++++++++++ > > 2 files changed, 30 insertions(+), 2 deletions(-) > > create mode 100644 arch/arm/mach-omap2/include/mach/omap_sgxdef.h > > > > diff --git a/arch/arm/mach-omap2/devices.c > b/arch/arm/mach-omap2/devices.c > > index 2271b9b..6349ee5 100644 > > --- a/arch/arm/mach-omap2/devices.c > > +++ b/arch/arm/mach-omap2/devices.c > > @@ -26,7 +26,7 @@ > > #include <plat/mux.h> > > #include <mach/gpio.h> > > #include <plat/mmc.h> > > - > > +#include <mach/omap_sgxdef.h> > > #include "mux.h" > > > > #if defined(CONFIG_VIDEO_OMAP2) || > defined(CONFIG_VIDEO_OMAP2_MODULE) > > @@ -786,6 +786,23 @@ static inline void omap_hdq_init(void) > > static inline void omap_hdq_init(void) {} > > #endif > > > > +struct sgx_platform_data omap_sgx_data = { > > + .set_min_bus_tput = NULL, > > +}; > > When I suggested you remove the #ifdef CONFIG_PM, I was expecting > you to leave the omap_pm_set_min_bus_tput() part. > > The point was that the driver itself should choose whether or > not to call > pdata->set_min_bus_tput() using #ifdef or other runtime decisions. I agree with your point. I will have only: .set_min_bus_tput = omap_pm_set_min_bus_tput, Let driver decide calling this using #ifdef or other runtime decisions. -Manjunath-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
