RE: [PATCH 6/9] OMAP:GPIO:hwmod: add GPIO hwmods for OMAP3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Cousson, Benoit
> Sent: Thursday, May 20, 2010 3:43 PM
> To: Varadarajan, Charulatha
> Cc: linux-omap@xxxxxxxxxxxxxxx; Nayak, Rajendra; paul@xxxxxxxxx; tony@xxxxxxxxxxx;
> khilman@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 6/9] OMAP:GPIO:hwmod: add GPIO hwmods for OMAP3
> 
> On 4/22/2010 5:55 PM, Varadarajan, Charulatha wrote:
> > Add hwmod structures for GPIO module on OMAP3
> 
> [snip]
> 
> > +
> > +static struct omap_hwmod omap3xxx_gpio1_hwmod = {
> > +       .name           = "gpio1_hwmod",
> 
> You should remove the "_hwmod" prefix of all the hwmod name in order to
> align with the convention we have on OMAP4.
> It will increase the data size without bringing any extra information.
> 

Yep. Will change the naming convention as followed in OMAP4.

> Thanks,
> Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux