On Wed, May 19, 2010 at 8:34 AM, Thomas Renninger <trenn@xxxxxxx> wrote: > On Wednesday 19 May 2010 15:11:03 Nishanth Menon wrote: >> Mike Chan had written, on 05/18/2010 08:30 PM, the following: >> > Specify new power field in struct omap_opp, which is >> > power exported in milliWatt. > ... >> > + totalpower += cpuacct_freq[i] * mpu_opps[i + 1].power; > ... >> > + unsigned long power; /* power consumed running at OPP in > milliWatts */ >> >> this conflicts with the OPP layer implementation. this structure will >> disappear for good. Okay, I wasn't sure what to use. The omap-pm branch uses omap_opp for the mpu frequencies. However it looks like struct prcm_config is used in linux-next for mpu frequencies, but there are deprecated comments around this struct definition so I'm not sure where what struct I should be using. > Ah yes, another question: > The power variable in struct omap_opp never gets initialized > with a sane value, something is wrong... > You're right, this last patch won't work on linux-next, it seems quite a bit has changed in the omap specific. Previously board files can register their OPP table which is an array of struct omp_opp, which is exactly what I do for Droid in our android-omap branch. I'm hoping some omap folks can offer some suggestions for what needs to be changed. -- Mike > Thomas > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
