Hi, On Fri, 2010-05-07 at 11:07 +0200, ext Guennadi Liakhovetski wrote: > This header adds defines for MIPI DSI and DCS commands and data formats. See > http://www.mipi.org/ for details. Did you notice that I have implemented MIPI DSI command mode support for OMAP processors? It's located in drivers/video/omap2/dss/dsi.c and one DSI panel driver is located in drivers/video/omap2/displays/panel-taal.c > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > --- > include/video/mipi_dsi.h | 99 ++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 99 insertions(+), 0 deletions(-) > create mode 100644 include/video/mipi_dsi.h > > diff --git a/include/video/mipi_dsi.h b/include/video/mipi_dsi.h > new file mode 100644 > index 0000000..5d3a6d6 > --- /dev/null > +++ b/include/video/mipi_dsi.h > @@ -0,0 +1,99 @@ > +/* > + * Mobile Industry Processor Interface (MIPI(R)) defines The file name is mipi_dsi.h, the comment talks about MIPI, and the file contains defines for MIPI DSI and MIPI DCS. If you want the file to contain defines about all MIPI specs, I think the file name should be just mipi.h. > + * > + * Copyright (C) 2010 Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > + * Copyright (C) 2006 Nokia Corporation > + * Author: Imre Deak <imre.deak@xxxxxxxxx> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > +#ifndef MIPI_DSI_H > +#define MIPI_DSI_H > + > +#include <linux/types.h> > + > +enum mipi_dsi_cmd { I think these are DSI datatypes, not commands. > + MIPI_DSI_DCS_SHORT_WRITE = 5, Please use the same number format for all enums. So this should be 0x05. > + MIPI_DSI_DCS_SHORT_WRITE_PARAM = 0x15, > + MIPI_DSI_COLOR_MODE_OFF = 2, > + MIPI_DSI_COLOR_MODE_ON = 0x12, > + MIPI_DSI_SHUTDOWN_PERIPHERAL = 0x22, > + MIPI_DSI_TURN_ON_PERIPHERAL = 0x32, > + MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM = 3, > + MIPI_DSI_GENERIC_SHORT_WRITE_1_PARAM = 0x13, > + MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM = 0x23, > + MIPI_DSI_GENERIC_READ_REQUEST_0_PARAM = 4, > + MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM = 0x14, > + MIPI_DSI_GENERIC_READ_REQUEST_2_PARAM = 0x24, > + MIPI_DSI_DCS_LONG_WRITE = 0x39, > + MIPI_DSI_SET_MAXIMUM_RETURN_PACKET_SIZE = 0x37, > + MIPI_DSI_NULL_PACKET = 9, > + MIPI_DSI_BLANKING_PACKET = 0x19, > + MIPI_DSI_GENERIC_LONG_WRITE = 0x29, > + MIPI_DSI_LOOSELY_PACKED_PIXEL_STREAM_YCBCR20 = 0xc, > + MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR24 = 0x1c, > + MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR16 = 0x2c, > + MIPI_DSI_PACKED_PIXEL_STREAM_30 = 0xd, > + MIPI_DSI_PACKED_PIXEL_STREAM_36 = 0x1d, > + MIPI_DSI_PACKED_PIXEL_STREAM_YCBCR12 = 0x3d, > + MIPI_DSI_PACKED_PIXEL_STREAM_16 = 0xe, > + MIPI_DSI_PACKED_PIXEL_STREAM_18 = 0x1e, > + MIPI_DSI_PIXEL_STREAM_3BYTE_18 = 0x2e, > + MIPI_DSI_PACKED_PIXEL_STREAM_24 = 0x3e, > +}; > + > +enum mipi_dcs_cmd { While the MIPI specs define a certain set of commands, the real panels usually implement also their own custom commands. That's why I don't think enum is a good choice here. Tomi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
