> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Wednesday, May 19, 2010 5:17 AM > To: Varadarajan, Charulatha > Cc: linux-omap@xxxxxxxxxxxxxxx; Nayak, Rajendra; paul@xxxxxxxxx; > khilman@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 09/11] OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO > init > > * Charulatha V <charu@xxxxxx> [100518 07:44]: > > This patch adds support for handling GPIO as a HWMOD FW adapted > > platform device for OMAP2PLUS chips. > > > > Signed-off-by: Charulatha V <charu@xxxxxx> > > + > > +/* > > + * gpio_init needs to be done before > > + * machine_init functions access gpio APIs. > > + * Hence gpio_init is a postcore_initcall. > > + */ Need for postcore_initcall is mentioned here as a common comment for all SoCs in the beginning of the file > > +#ifdef CONFIG_ARCH_OMAP2 > > +static int __init omap242x_gpio_init(void) > > +{ if (!cpu_is_omap2420()) > > + return -EINVAL; > > + > > + return gpio_init(METHOD_GPIO_24XX); > > +} > > +postcore_initcall(omap242x_gpio_init); > > + > > +static int __init omap243x_gpio_init(void) > > +{ > > + if (!cpu_is_omap2430()) > > + return -EINVAL; > > + > > + return gpio_init(METHOD_GPIO_24XX); > > +} > > +postcore_initcall(omap243x_gpio_init); > > +#endif > > + > > +#ifdef CONFIG_ARCH_OMAP3 > > +static int __init omap3xxx_gpio_init(void) > > +{ > > + if (!cpu_is_omap34xx()) > > + return -EINVAL; > > + > > + return gpio_init(METHOD_GPIO_24XX); > > +} > > +postcore_initcall(omap3xxx_gpio_init); > > +#endif > > + > > +#ifdef CONFIG_ARCH_OMAP4 > > +static int __init omap44xx_gpio_init(void) > > +{ > > + if (!cpu_is_omap44xx()) > > + return -EINVAL; > > + > > + return gpio_init(METHOD_GPIO_44XX); > > +} > > +postcore_initcall(omap44xx_gpio_init); > > +#endif > > What was the reason again for using postcore_initcall? You mentioned > it somewhere, but I forgot already.. Maybe put that into the patch > description too? Okay. I will add it in this patch description too. > > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
