On Tue, May 18, 2010 at 04:46:53PM -0700, Kevin Hilman wrote: > If the _probe() method fails, the 'ts' struct is freed, yet it is > still used as the drvdata passed to suspend/resume/remove methods. > Even though the input device does not get registerd, the driver's > suspend/resume methods still get called as it's a registered SPI > device. This patch adds sanity checks to these methods to ensure that > drvdata is valid before using it. > This is a load of crap. If probe() fails that means that driver does not manage the device and thus ads7846_suspend() and ads7846_resume() should not be called _at all_. If SPI core manages to call random methods from the drivers that failed to bind to a device that should be fixed in SPI core. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
