Moi Jarkko,
On Tue, May 18, 2010 at 01:06:00PM +0200, Jarkko Nikula wrote:
> Signed-off-by: Jarkko Nikula <jhnikula@xxxxxxxxx>
I don't have any major objections on this one. I'd just add a patch description though.
Other than that:
Acked-by: Eduardo Valentin <eduardo.valentin@xxxxxxxxx>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 43 ++++++-------------------
> 1 files changed, 11 insertions(+), 32 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
> index 8179d55..ead7ee1 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -272,48 +272,27 @@ static struct omap2_hsmmc_info mmc[] __initdata = {
> {} /* Terminator */
> };
>
> -static struct regulator_consumer_supply rx51_vmmc1_supply = {
> - .supply = "vmmc",
> - .dev_name = "mmci-omap-hs.0",
> -};
> +static struct regulator_consumer_supply rx51_vmmc1_supply =
> + REGULATOR_SUPPLY("vmmc", "mmci-omap-hs.0");
>
> -static struct regulator_consumer_supply rx51_vaux3_supply = {
> - .supply = "vmmc",
> - .dev_name = "mmci-omap-hs.1",
> -};
> +static struct regulator_consumer_supply rx51_vaux3_supply =
> + REGULATOR_SUPPLY("vmmc", "mmci-omap-hs.1");
>
> -static struct regulator_consumer_supply rx51_vsim_supply = {
> - .supply = "vmmc_aux",
> - .dev_name = "mmci-omap-hs.1",
> -};
> +static struct regulator_consumer_supply rx51_vsim_supply =
> + REGULATOR_SUPPLY("vmmc_aux", "mmci-omap-hs.1");
>
> static struct regulator_consumer_supply rx51_vmmc2_supplies[] = {
> /* tlv320aic3x analog supplies */
> - {
> - .supply = "AVDD",
> - .dev_name = "2-0018",
> - },
> - {
> - .supply = "DRVDD",
> - .dev_name = "2-0018",
> - },
> + REGULATOR_SUPPLY("AVDD", "2-0018"),
> + REGULATOR_SUPPLY("DRVDD", "2-0018"),
> /* Keep vmmc as last item. It is not iterated for newer boards */
> - {
> - .supply = "vmmc",
> - .dev_name = "mmci-omap-hs.1",
> - },
> + REGULATOR_SUPPLY("vmmc", "mmci-omap-hs.1"),
> };
>
> static struct regulator_consumer_supply rx51_vio_supplies[] = {
> /* tlv320aic3x digital supplies */
> - {
> - .supply = "IOVDD",
> - .dev_name = "2-0018"
> - },
> - {
> - .supply = "DVDD",
> - .dev_name = "2-0018"
> - },
> + REGULATOR_SUPPLY("IOVDD", "2-0018"),
> + REGULATOR_SUPPLY("DVDD", "2-0018"),
> };
>
> static struct regulator_init_data rx51_vaux1 = {
> --
> 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
