shweta gulati <shweta.gulati@xxxxxx> writes: > From: Shweta Gulati <shweta.gulati@xxxxxx> > > According to Defect OMAPS00210499 CAM, DSS and USBHOST should stay > in OFF state instead of Retention in OS Idle Path. Please summarize the above defect. > This Patch puts all the powerdomain in OFF state by default > in pm init code and ensures that Mpu next state is OFF only > before it goes to Suspend/Idle and RET initiallly as that > could have caused system to hang if ROM code issues WFI. That's a long sentence that is not clear. It attempts to explain _what_ is happening, but is not clear about why. IIUC, this same patch could be done with a one-liner patch[1] > Signed-off-by: Vishwanath BS <Vishwanath.bs@xxxxxx> > Signed-off-by: Shweta Gulati <shweta.gulati@xxxxxx> > --- -EDOESNOTAPPLY Please state what this patch applies to. It does not apply to mainline, linux-omap or the PM branch. I see OSWR related code in this patch which means it's clearly against an internal tree. Because of that, I didn't read the rest of the patch. Kevin [1] diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c index 5039b35..5b93a84 100644 --- a/arch/arm/mach-omap2/pm34xx.c +++ b/arch/arm/mach-omap2/pm34xx.c @@ -74,7 +74,7 @@ static inline bool is_suspending(void) #define OMAP343X_TABLE_VALUE_OFFSET 0x30 #define OMAP343X_CONTROL_REG_VALUE_OFFSET 0x32 -u32 enable_off_mode; +u32 enable_off_mode = 1; u32 sleep_while_idle; u32 wakeup_timer_seconds; u32 wakeup_timer_milliseconds; -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
