> -----Original Message----- > From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] > Sent: Thursday, May 13, 2010 2:36 PM > To: Gomez Castellanos, Ivan > Cc: linux-omap@xxxxxxxxxxxxxxx; Hiroshi DOYU; Ameya Palande; Menon, > Nishanth > Subject: Re: [PATCH 01/13] DSPBRIDGE: Replace mem_calloc() by kzalloc() or > __vmalloc() > > On Fri, Apr 9, 2010 at 2:43 AM, Gomez Castellanos, Ivan > <ivan.gomez@xxxxxx> wrote: > > diff --git a/drivers/dsp/bridge/wmd/ue_deh.c > b/drivers/dsp/bridge/wmd/ue_deh.c > > index 75a62b0..6c1b318 100644 > > --- a/drivers/dsp/bridge/wmd/ue_deh.c > > +++ b/drivers/dsp/bridge/wmd/ue_deh.c > > @@ -239,8 +239,8 @@ void bridge_deh_notify(struct deh_mgr *hdeh_mgr, u32 > ulEventMask, u32 dwErrInfo) > > printk(KERN_INFO > > "bridge_deh_notify: DSP_MMUFAULT, fault " > > "address = 0x%x\n", (unsigned > int)fault_addr); > > - dummy_va_addr = > > - (u32) mem_calloc(sizeof(char) * 0x1000, > MEM_PAGED); > > + dummy_va_addr = (u32) kzalloc(sizeof(char) * > 0x1000, > > + > GFP_ATOMIC); > > sizeof(foo) returns the size of foo in chars, so obviously sizeof(char) is > 1. Yes, this should be removed. I think you sent a patch to change the type of dummy_va_addr and also removed the sizeof(). I found your patch: dsp-bridge: deh: fix dummy_va_addr It can be applied after the discussion on "Fix Kernel memory poison overwritten after DSP_MMUFAULT" is finished. Regards, Ivan > > -- > Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
