Re: [PATCH v5 1/5] omap3: pm: fix for twl4030 script load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> 
> Hi Eduardo,
> 
> The load_twl4030_script() is called from twl4030_power_init() which is again
> called from twl_probe(), and this is getting called before
> omap3_idle_init().
> 
> So the scripts are loaded before the cpuidle is initialized.
> Then I don't think the system will hit sys_off before loading the scripts.
> 
> Regards,
> Lesly
> 

Hi,

I agree that in our usecase the problem can probably never happen. But
what if NSLEEP2 would be controlled by some external component (Ie. not
OMAP) ? I don't think we can be sure that the sleep script will not be
executed while the wakeup script is not yet loaded (assuming they would
be loaded in the wrong order). Note that loading the script also sets
the address in the corresponding TWL4030 register. So I think this
safeguard is still useful.

Thanks,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux