Nishanth Menon <menon.nishanth@xxxxxxxxx> wrote: > -linux-arm > > On 05/10/2010 10:53 PM, S, Venkatraman wrote: >>> >>> -----Original Message----- >>> From: menon.nishanth@xxxxxxxxx >>> [mailto:menon.nishanth@xxxxxxxxx] On Behalf Of Menon, Nishanth >>> Sent: Tuesday, May 11, 2010 5:02 AM >>> To: S, Venkatraman >>> Cc: linux-omap@xxxxxxxxxxxxxxx; >>> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Tony Lindgren; >>> Chikkature Rajashekar, Madhusudhan >>> Subject: Re: [PATCH RESEND] update omap3 features bitmap and >>> API to generic names >>> >>> On Mon, May 10, 2010 at 2:55 PM, Venkatraman S >>> <svenkatr@xxxxxx> wrote: >>>> >>>> OMAP3 features bitmap is used a method to check for SoC >>>> specific features. This patch renames the global variables and the >>>> accessor functions to use a generic name from omap3_* to >>>> omap_* >>>> >>>> Signed-off-by: Venkatraman S<svenkatr@xxxxxx> >>>> CC: Nishant Menon<nm@xxxxxx> >>> >>> Just for the patchworks >>> NAK - discussed before - >>> http://marc.info/?l=linux-omap&m=127349696800651&w=2 >> >> This patch doesn't have the descriptor load changes, and just the rename. >> Did you take a look at it first? > > Arrgh - my bad - there was no reference to previous discussions or anything > in this patch, please do add references in diffstat section if you are > refering to a previous discussed strategy to help the reviewers > differentiate and understand you better. > > overall this still opens up a question for me -> can we blindly replace > omap3-features with omap features? how do we think of omap1,2,3,4 are > handled consistently with a 32 bit field? > > I agree on the need to have a omap independent field, but is omap3_features > the one we need to modify OR should we be introducing a new field? > > my vote goes for introducing a new field. > You are confusing the interface with implementation (or rather, worrying about both of them simultaneously). The interface has to be consistent and SoC independent, to the extent possible. So the macro changes are relevant and readable / extensible. Regarding the variable name (implementation):- Given the minimal set that we have (5 -6 fields today, so there is room for 25 more 'features" still), I don't think we should over-engineer it now to accomodate all permutations and use cases. It's not even found use beyond 1 or 2 files. YAGNI ? Regards, Venkat. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
