Hi Charu, "Varadarajan, Charulatha" <charu@xxxxxx> writes: > While adapting some drivers to HWMOD way, I tried using pm_runtime > APIs. My understanding is that instead of using clock FW APIs or > omap_device APIs, we can make use of pm_runtime APIs. > > But, I observed that pm_runtime_enable() does not enable the clocks > (fck/ick). pm_runtime_enable() is not the equivalent of enabling the clocks. This function simply enables runtime PM _functionality_ for that device, it doesn't actually do any HW manipulation. The way that clocks are enabled/disabled is by using the pm_runtime_get*() and pm_runtime_put*() calls. These do usage couting in the runtime PM core and when there's a zero use-count, then pm_runtime_idle() is called which will use omap_device API to disable the clocks. Similar for the enable path. [...] > I am using origin/pm-wip/runtime branch with patches to adapt > watchdog to HWMOD FW on top of. > > I use "omap3_defconfig" and test on 3430SDP. > > On mmc branch I am working on top of the following commit: > commit fe64f0fab492651d7f9296b9d830f2c11844b546 > Author: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > Date: Wed Jan 20 09:48:52 2010 -0800 > > OMAP2/3 MMC: initial conversion to runtime PM > I recommend you look at the details of this patch you will see that the clock enable/disable calls were replaced by runtime PM _get() and _put() calls. The _enable() call is just done at _probe() time. Hope that helps, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
