RE: [PATCH v1 2/3] OMAP4: Ethernet: KS8851 Board Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Manjunath,

> > +
> > +static void omap_ethernet_init(void)
> > +{
> > +	gpio_request(ETHERNET_KS8851_POWER_ENABLE, "ethernet");
> > +	gpio_direction_output(ETHERNET_KS8851_POWER_ENABLE, 1);
> > +	gpio_request(ETHERNET_KS8851_QUART, "quart");
> > +	gpio_direction_output(ETHERNET_KS8851_QUART, 1);
> > +	gpio_request(ETHERNET_KS8851_IRQ, "ks8851");
> 
> Any reason for not checking return value of gpio_request()?
> 

Thought initially about them as dedicated lines for ethernet avoiding
both reasons to check for a gpio's request:

 1. invalid gpio
 2. already claimed gpio

Best Regards
Abraham

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux