On Sun, May 02, 2010 at 02:08:58AM +0300, Felipe Contreras wrote: > On Sat, May 1, 2010 at 8:33 PM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote: > > On Sat, May 01, 2010 at 05:47:57PM +0300, Felipe Contreras wrote: > >> The easiest solution would be to make mailbox_mach built-in when > >> mailbox is configured, however, mailbox_mach needs mailbox to be > >> loaded. > > > > generally platform_device instantiation isn't compiled as a module. The > > patch below should probably help but I didn't test it. > > Yeah, but as I said above... that doesn't work: > > arch/arm/mach-omap2/built-in.o: In function `omap2_mbox_probe': > /data/public/dev/omap/linux-omap/arch/arm/mach-omap2/mailbox.c:389: > undefined reference to `omap_mbox_register' > arch/arm/mach-omap2/built-in.o: In function `omap2_mbox_remove': > /data/public/dev/omap/linux-omap/arch/arm/mach-omap2/mailbox.c:439: > undefined reference to `omap_mbox_unregister' now I see the problem. You shouldn't put that kind of stuff on the driver. The driver can be built as a module but the device will probably be built-in. You'll need a more intrusive change to fix that, I guess. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
