Thara Gopinath <thara@xxxxxx> writes: > OMAP3430 uses the 65nm version of the smartreflex IP where as > OMAP3630 and OMAP4430 uses the 45nm updated IP. > > This patch adds support for the updated smartreflex IP used > in OMAP3630 and OMAP4 in the smartreflex driver. > > Major changes between the two versions of IP involve: > 1. Change in offset position for ERRCONFIG and SENERROR registers > 2. Change in bit positions for VP bound interrupt enable and status > in ERRCONFIG register. > 3. Change in bit positions and width of SENNENABLE and SENPENABLE > bits in SRCONFIG registers. > 4. Introduction of separate irq registers for MCU bound interrupts. > 5. Removal of clockactivity bits in ERRCONFIG and introduction of > idlemode and wakeupenable bits in ERRCONFIG. > > Signed-off-by: Thara Gopinath <thara@xxxxxx> Looks good. One minor comment for discussion below... [...] > @@ -619,6 +717,7 @@ static int __devinit omap_smartreflex_probe(struct platform_device *pdev) > sr_info->srid = pdev->id; > sr_info->is_autocomp_active = 0; > sr_info->clk_length = 0; > + sr_info->sr_ip_type = odev->hwmods[0]->class->rev; I'm not crazy about drivers having to know the details of hwmod structs. I'd suggest a HWMOD API for getting this revision. Other ideas? Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
