* Eduardo Valentin <eduardo.valentin@xxxxxxxxx> [100427 03:08]: > Hello Tony, > > On Mon, Apr 26, 2010 at 08:28:12PM +0200, ext Tony Lindgren wrote: > > * Eduardo Valentin <eduardo.valentin@xxxxxxxxx> [100426 01:20]: > > > + > > > + /* Append OMAP3 IDCODE, Production ID and Die ID to system_soc_info */ > > > + sz = strlen(system_soc_info); > > > + snprintf(system_soc_info + sz, SYSTEM_SOC_INFO_SIZE - sz, > > > + "\n\tIDCODE\t: %08x\n\tPr. ID\t: %08x %08x %08x %08x\n" > > > + "\tDie ID\t: %08x %08x %08x %08x\n", > > > + read_tap_reg(OMAP_TAP_IDCODE), > > > + read_tap_reg(OMAP_TAP_PROD_ID_0), > > > + read_tap_reg(OMAP_TAP_PROD_ID_1), > > > + read_tap_reg(OMAP_TAP_PROD_ID_2), > > > + read_tap_reg(OMAP_TAP_PROD_ID_3), > > > + read_tap_reg(OMAP_TAP_DIE_ID_0), > > > + read_tap_reg(OMAP_TAP_DIE_ID_1), > > > + read_tap_reg(OMAP_TAP_DIE_ID_2), > > > + read_tap_reg(OMAP_TAP_DIE_ID_3)); > > > } > > > > > > /* > > > > We should not expose the Die ID info unless specifically compiled in > > with some Kconfig option. Please search for "pentium serial number privacy" > > or similar. > > Yeah, I remember now that you actually have already asked to do it. I'll > repost this series again with this change. It will couple with the same > protection mechanism there is for x86 pn. it is not a compilation config, > but a kernel parameter: > > > static int __init x86_serial_nr_setup(char *s) > { > disable_x86_serial_nr = 0; > return 1; > } > __setup("serialnumber", x86_serial_nr_setup); Sounds good to me. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html