Hi Hiroshi, > -----Original Message----- > From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] > Sent: Saturday, April 24, 2010 1:45 AM > To: Kanigeri, Hari > Cc: Gupta, Ramesh; linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 4/4][v4] OMAP:iommu- add TLB preservation support > > From: "ext Kanigeri, Hari" <h-kanigeri2@xxxxxx> > Subject: RE: [PATCH 4/4][v4] OMAP:iommu- add TLB preservation support > Date: Sat, 24 Apr 2010 01:43:19 +0200 > > > Hi Hiroshi, > > > >> > >> diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c > >> index 1e83fac..d09a0a1 100644 > >> --- a/arch/arm/plat-omap/iommu.c > >> +++ b/arch/arm/plat-omap/iommu.c > >> @@ -25,6 +25,9 @@ > >> > >> #include "iopgtable.h" > >> > >> +#define for_each_iotlb_cr(obj, n, i, cr) \ > >> + for (i = 0; (i < n) && (cr = get_iotlb_cr(obj, i)); i++) > >> + > > -- This code is giving compilation error. > > Should be like: > > +#define for_each_iotlb_cr(obj, n, __i, cr) \ > + for (__i = 0; \ > + (__i < (n)) && (cr = __iotlb_read_cr((obj), __i), true); \ > + __i++) > + -- The change looks good to me. Thank you, Best regards, Hari -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
