"Arce, Abraham" <x0066660@xxxxxx> writes: > Keyboard controller for OMAP4 with built-in scanning algorithm. > The following implementations are used: > > - matrix_keypac.c logic > - hwmod framework > - threaded irq > > Signed-off-by: Syed Rafiuddin <rafiuddin.syed@xxxxxx> > Signed-off-by: Abraham Arce <x0066660@xxxxxx> Some general comments... What's missing here is a separation of the driver and the device. What you need is for arch code to register a platfrom_device (using hwmod + omap_device). Then this driver will use the standard platform_device resource calls to get its base address, IRQs, etc. and any platform_data. IOW, as Felipe mentioned, the driver should not be doing the hwmod + omap_device init and registration. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
