On Tue, Apr 20, 2010 at 2:51 PM, Kanigeri, Hari <h-kanigeri2@xxxxxx> wrote: >> This looks like based on an old version of omap3-iommu.c; maybe you >> should update it. >> > > -- I thought about doing this, but then I felt it doesn't make sense putting OMAP4 specific definitions in a file that is named after omap3 and all the functions in it having omap3 pre-fix. > > May be we can rename the omap3-iommu file to omap-iommu and change omap3 prefix in functions to omap, and just change the devices structure based on the platform. This way it would look more generic to all OMAPs. > > Please let me know your thoughts. Er, that's not what I meant. I meant that the omap4-iommu.c that you are proposing looks very different from the current omap3-iommu.c, for example there's no 'struct iommu_device'. Check it out: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=arch/arm/mach-omap2/omap3-iommu.c;h=fbbcb5c8336760c52085f873107930ec7f57422c;hb=HEAD But I also like your idea of a generic omap-iommu. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
