RE: [PATCH] ARM:iommu support for OMAP4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> This looks like based on an old version of omap3-iommu.c; maybe you
> should update it.
>

-- I thought about doing this, but then I felt it doesn't make sense putting OMAP4 specific definitions in a file that is named after omap3 and all the functions in it having omap3 pre-fix.

May be we can rename the omap3-iommu file to omap-iommu and change omap3 prefix in functions to omap, and just change the devices structure based on the platform. This way it would look more generic to all OMAPs.

Please let me know your thoughts.

Thank you,
Best regards,
Hari

> -----Original Message-----
> From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx]
> Sent: Monday, April 19, 2010 2:12 AM
> To: Kanigeri, Hari
> Cc: linux-omap@xxxxxxxxxxxxxxx; Doyu Hiroshi (Nokia-D/Helsinki);
> Shilimkar, Santosh; tony@xxxxxxxxxxx
> Subject: Re: [PATCH] ARM:iommu support for OMAP4
> 
> On Fri, Apr 16, 2010 at 7:17 PM, Kanigeri, Hari <h-kanigeri2@xxxxxx>
> wrote:
> > From 708914e1a82a608d423b050cb31b4deb46eb8411 Mon Sep 17 00:00:00 2001
> > From: Hari Kanigeri <h-kanigeri2@xxxxxx>
> > Date: Mon, 8 Mar 2010 17:55:21 -0600
> > Subject: [PATCH] ARM:iommu support for OMAP4
> >
> > This patch provides the iommu support for OMAP4 co-processors.
> >
> > Signed-off-by: Hari Kanigeri <h-kanigeri2@xxxxxx>
> 
> This looks like based on an old version of omap3-iommu.c; maybe you
> should update it.
> 
> --
> Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux