RE: [RFC] [PATCH 2/3] OMAP4: Keyboard Board Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Vimal,

> > Signed-off-by: Abraham Arce <x0066660@xxxxxx>
> > ---
> 
> 'Form: Syed Rafiuddin', but not 'Signed-off-by:'... is it correct?

Yes, it is missing, added it in 02 && 03 patches...

<snip>

> >
> > -       KEY(7, 0, KEY_UNKNOWN),
> > +       KEY(7, 0, KEY_LEFTSHIFT),
> >        KEY(7, 1, KEY_ENTER),
> >        KEY(7, 2, KEY_CAPSLOCK),
> >        KEY(7, 3, KEY_SPACE),
> > @@ -119,31 +116,23 @@ static int omap_keymap[] = {
> >        0,
> >  };
> 
> Are you aware of that interpretation of 'row' and 'col' get reversed
> in matrix keymap framework.

I forgot, changed now...

> Also last element '0' should be removed.
> 

Removed...

Best Regards
Abraham
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux