Re: [PATCH v3] board-omap3-beagle: add DSS2 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 14 apr 2010, om 14:01 heeft Grazvydas Ignotas het volgende geschreven:

> On Wed, Apr 14, 2010 at 2:37 PM, Koen Kooi <koen.kooi@xxxxxxxxx> wrote:
>> This patch adds DSS2 support to the beagleboard boardfile. DVI and TV-out are supported.
>> 
>> Changes since v1:
>>        * removed beagle_panel_enable_tv() and beagle_panel_disable_tv()
> 
> oh no you didn't, they're still there :)
> And changelog should not go into patch description

Gah! Let me get some coffee before sending v4 :)

> 
>> Changes since v2:
>>        * changed to REGULATOR_SUPPLY(_name, _dev_name) for dss regulators
>> 
>> Signed-off-by: Koen Kooi <koen@xxxxxxxxxxxxxxxxxxxxx>
>> ---
> 
> comments and changelog goes here
> 
>>  arch/arm/mach-omap2/board-omap3beagle.c |  126 ++++++++++++++++++++++++-------
>>  1 files changed, 99 insertions(+), 27 deletions(-)
>> 
>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
>> index 962d377..4b595b0 100644
>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> 
> <snip>
> 
>> +static int beagle_panel_enable_tv(struct omap_dss_device *dssdev)
>> +{
>> +#define ENABLE_VDAC_DEDICATED           0x03
>> +#define ENABLE_VDAC_DEV_GRP             0x20
>> +
>> +       twl_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
>> +                       ENABLE_VDAC_DEDICATED,
>> +                       TWL4030_VDAC_DEDICATED);
>> +       twl_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER,
>> +                       ENABLE_VDAC_DEV_GRP, TWL4030_VDAC_DEV_GRP);
>> +
>> +       return 0;
>> +}
>> +
>> +static void beagle_panel_disable_tv(struct omap_dss_device *dssdev)
>> +{
>> +       twl_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, 0x00,
>> +                       TWL4030_VDAC_DEDICATED);
>> +       twl_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, 0x00,
>> +                       TWL4030_VDAC_DEV_GRP);
>> +}
> 
> <snip>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux