> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Thursday, March 11, 2010 3:13 AM > To: Kevin Hilman > Cc: linux-omap@xxxxxxxxxxxxxxx; Shilimkar, Santosh > Subject: Re: [PATCH 2/2] OMAP4: fix temporary hacks that break multi-omap PM > > * Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> [100310 09:16]: > > When building for multi-omap, and OMAP4 is enabled, CONFIG_ARCH_OMAP4 > > will be true and prevent included code from building/running for > > OMAP2/3 as well. > > > > This problem exists in io.c where some hwmod/PM/SDRC init code is > > prevented from running even on OMAP2/3 when OMAP4 is included in a > > multi-OMAP build. > > > > A quick glance suggests that this #ifndef is no longer needed in most > > of the cases. In the remaining cases, the function is wrapped with > > "if (cpu_is_omap24xx() || cpu_is_omap34xx())" which will be optimized > > out for OMAP4-only builds. > > > > Note that this is only a short-term fix. Longer-term, OMAP4 > > needs to create init functions for SDRC and hwmod late-init. > > Good to get rid of the temporary hacks. Santosh, maybe grep > to see if there are other hacks left that can be now removed? > Tony, We have almost cleaned up all the hacks in platform code except the one around ongoing hwmod work. Will check if I have missed anything. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html