RE: struct dmtimer definition not available in header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Benoit, Kelvin,

> >>                         OMAP2_L4_IO_ADDRESS(gpt_phys_base +
> >>                                         OMAP_TIMER_COUNTER_OFFSET);
> >>
> >>         gt_rate = clk_get_rate(omap_dm_timer_get_fclk(gpt));
> >>         omap_dm_timer_set_load_start(gpt, 0, 0);
> >>
> >> 	.
> >> 	.
> >> 	.
> >> }
> >>
> >> I am not able to reference *gpt as the file does not know about struct
> >omap_dm_timer. I have included plat/dmtimer.h.
> >>
> >> Why doesn't the dmtimer struct definition appear in plat/dmtimer.h ?
> >> Is there any reason for this?
> >
> >The declaration appears there, but the definition is hidden.
> >
> >In fact, it is is hidden to prevent exactly the type of thing you're
> >trying to do, and to provide all access to DM timer details via the DM
> >timer API.
> >
> >Looking at your example, I'm guessing you're trying to implement one
> >of my ideas for the SDRC delay calculation by passing the base address
> >to the assembly routine.
> >
> >As I suggested in my original patch, the better way to do this would
> >be to extend the dmtimer API, and use C instead of assembly.
> 
> Considering the accuracy needed in that case and the number of iteration
> (10000), I clearly don't think we need to ack the dmtimer API to read the
> timer value in ASM.
> Using the regular omap_dm_timer_read_counter before and after calling the
> ASM function will be enough.
> Moreover the current ASM function can be simplify to reduce the overhead.
>

Thank you.
I am trying with DMtimer API. I will even reduce the dmtimer part of ASM code and run only the loop in ASM.


Thanks and Regards
Pramod
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux