Hi, > + > + chip = kzalloc(sizeof(struct tca6416_keypad_chip), GFP_KERNEL); > + if (chip == NULL) > + return -ENOMEM; Check for i2c functionality support ? > + ret = request_irq(chip->irqnum, tca6416_keys_isr, > + IRQF_SHARED | IRQF_TRIGGER_FALLING , > + "tca6416-keypad", chip); > + if (ret) { > + dev_dbg(&client->dev, > + "Unable to claim irq %d; error %d\n", > + chip->irqnum, ret); > + goto fail3; > + } > + disable_irq(chip->irqnum); The error path needs to free_irq() in case of any failure after this, for an interrupt based driver. Thanks, Anirudh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html