Margarita, > Mark, > > I'll re-submit the patch series using twl6040_codec instead of > twl6030_codec, twl6030 is the power companion chip and twl4030 is > the audio chip, so in the case of this patch should I send an > incremental patch to rename it? As shown in TI's website ([1], [2]): - TWL6030 contains PM, USB, I2C, etc - TWL6040 contains only audio Then, TWL6030 is the MFD and TWL6040 is a simple audio codec, and this patch ([PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 codec) is not valid since the codec doesn't belong to the MFD anymore. TWL6040 can become a MFD to support vibrator as Mark pointed out. -Misa [1] http://focus.ti.com/general/docs/wtbu/wtbuproductcontent.tsp?templateId=6123&navigationId=12845&contentId=53245 [2] http://focus.ti.com/pdfs/wtbu/twl60x0flyer_slyv008.pdf > Regards, > Margarita > > > -----Original Message----- > > From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx] > > Sent: Wednesday, February 24, 2010 7:23 AM > > To: Samuel Ortiz > > Cc: Liam Girdwood; Olaya, Margarita; alsa-devel@alsa- > project.org; linux-omap@xxxxxxxxxxxxxxx > > Subject: Re: [PATCHv4 1/7] OMAP4: PMIC: Add support for twl6030 > codec > > > > On Wed, Feb 24, 2010 at 12:13:29PM +0100, Samuel Ortiz wrote: > > > > > > Samuel are you OK with this ? > > > > > That seems fine, yes. > > > Acked-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > > > > OK, I've applied this one now - the cross tree issues mean it > seems > > better to get into 2.6.34. I'll review the rest of the patches > now. > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@xxxxxxxxxxxxxxxx > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
