Hi Hiroshi, >-----Original Message----- >From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] >Sent: Thursday, February 18, 2010 1:16 AM >To: Guzman Lugo, Fernando >Cc: linux-omap@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 3/6] Mailbox: change mailbox version print to pr_debug > >Hi Fernando, > >From: "ext Guzman Lugo, Fernando" <x0095840@xxxxxx> >Subject: RE: [PATCH 3/6] Mailbox: change mailbox version print to pr_debug >Date: Thu, 18 Feb 2010 07:22:03 +0100 > >> >> >>>-----Original Message----- >>>From: Hiroshi DOYU [mailto:Hiroshi.DOYU@xxxxxxxxx] >>>Sent: Wednesday, February 17, 2010 9:14 AM >>>To: Guzman Lugo, Fernando >>>Cc: linux-omap@xxxxxxxxxxxxxxx >>>Subject: Re: [PATCH 3/6] Mailbox: change mailbox version print to >pr_debug >>> >>>Hi Fernand, >>> >>>From: "ext Guzman Lugo, Fernando" <x0095840@xxxxxx> >>>Subject: [PATCH 3/6] Mailbox: change mailbox version print to pr_debug >>>Date: Sat, 13 Feb 2010 02:40:41 +0100 >>> >>>> From 60e21e76773de379deb41ff166f9679b7078276f Mon Sep 17 00:00:00 2001 >>>> From: Fernando Guzman Lugo <x0095840@xxxxxx> >>>> Date: Wed, 10 Feb 2010 17:08:20 -0600 >>>> Subject: [PATCH] Mailbox: change mailbox version print to pr_debug >>>> >>>> it is not useful printing the version every time mailbox is used >>>> instead change it to pr_debug in case someone needs to see the >>>> version can enable the print. >>> >>>I just found that, if you put the line printing version into debug >>>mode, then "mbox_read_reg(MAILBOX_REVISION)" should be also done only >>>in debug mode. This value wouldn't be necessary if it didn't print. >>> >>>Considering this printing again, this prints a message only when H/W >>>initialization is done correctly, most likely only *once* at >>>booting. This informs us of the result that a mailbox H/W itself is >>>set up and some mailbox related modules are loaded successfully. So >>>keeping this makes sense a little bit more rather than shutting this >>>completely silence. >> >> The thing was that the tests I ran does a lot of install and >> uninstall bridge module that why I saw a lot of this print, but yes >> you are right in normal operation it should be printed once. On the >> other hand if this is used to state loaded successfully maybe the >> print should be changed to more meaningfully like >> "mailbox revision4.0 running or loaded" >> >> But, let drop this patch in this moment. I will send all the patches >> again. > >Agreed. > >When you resend them again, then please include mine [5/6] attached >too. It's much easier. > >I ack'ed all of them. Oops, I have already send them, but let me send them again including your patch and description and your ack's Regards, Fernando. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
