Re: [PATCH 3/6] Mailbox: change mailbox version print to pr_debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Fernand,

From: "ext Guzman Lugo, Fernando" <x0095840@xxxxxx>
Subject: [PATCH 3/6] Mailbox: change mailbox version print to pr_debug
Date: Sat, 13 Feb 2010 02:40:41 +0100

> From 60e21e76773de379deb41ff166f9679b7078276f Mon Sep 17 00:00:00 2001
> From: Fernando Guzman Lugo <x0095840@xxxxxx>
> Date: Wed, 10 Feb 2010 17:08:20 -0600
> Subject: [PATCH] Mailbox: change mailbox version print to pr_debug
> 
> it is not useful printing the version every time mailbox is used
> instead change it to pr_debug in case someone needs to see the
> version can enable the print.

I just found that, if you put the line printing version into debug
mode, then "mbox_read_reg(MAILBOX_REVISION)" should be also done only
in debug mode. This value wouldn't be necessary if it didn't print.

Considering this printing again, this prints a message only when H/W
initialization is done correctly, most likely only *once* at
booting. This informs us of the result that a mailbox H/W itself is
set up and some mailbox related modules are loaded successfully. So
keeping this makes sense a little bit more rather than shutting this
completely silence.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux