Hi all, On Thu, 2010-02-11 at 16:53 +0100, Contreras Felipe (Nokia-D/Helsinki) wrote: > On Wed, Feb 10, 2010 at 06:31:35PM +0100, ext Guzman Lugo, Fernando wrote: > > >-----Original Message----- > > >From: Felipe Contreras [mailto:felipe.contreras@xxxxxxxxx] > > >> Resource cleanup does not support that even without my proposed changes. > > > > > >Aha! I suspected it :P > > > > > Resource cleanup does not support that because it tries to unreserved > > every chunk mapped. However it does not means the dspbridge does not > > support reserving a big chunk of memory and mapping small parts of > > that memory, but I have not tested it to confirm if it works. > > I think I did once and it didn't work, but I thought the problem was in > my app. Anyway I think we should either forget about this use-case or > fix the resource cleaning. > > > >> I just proposed a solution which fixes two issues in one patch. > > >> Moreover if this change is merged when the second issue be fixed this > > >> patch will not needed anymore, so why don't merge the patch which > > >> fixes both errors at this moment? > > > > > >simple patches > complicated patches > > The patch is more simple than it looks. > > Only one way to know :) > > > >Personally I think your patches should be a continuation to the patches > > >I just proposed. > > Yes, I think it would be better. > > Cool. > Thanks for reviewing the patch! After going through your comments I feel the current patch is inadequate to do proper resource cleanup :( I am working on something which should take care of map and reserve both. Basically I am working on separating current DMM resource accounting for map and reserve, which should fix all the problems. Will post the patchset soon! Cheers, Ameya. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
