> > -----Original Message----- > > From: Shilimkar, Santosh > > Sent: Wednesday, January 20, 2010 12:52 PM > > To: Pagare, Abhijit; Paul Walmsley; Pagare, Abhijit > > Cc: tony@xxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; linux-arm- > > kernel@xxxxxxxxxxxxxxxxxxx > > Subject: RE: [PATCH] OMAP CPU ID: fix OMAP4 build failure > > > > Abhijit, > > > > <snip> > > > > > I had used this flag earlier as there was nothing fixed as to name it as > > ES1 that time. So now it can > > > be migrated from CHIP_IS_OMAP4430 to CHIP_IS_OMAP4430ES1. I think > > CHIP_IS_OMAP4430 would be redundant > > > in that case and should be removed. A patch would be essential to take > > care of that in the places > > > where it is used. If you feel the same I can send a patch for fixing > > this. > > > > > > > Tony has already created the patch. Please use that and test it on OMAP4. > > I will test it on OMAP4 but my point was as follows, > > The patch that is sent has both the definitions of CHIP_IS_OMAP4430 and CHIP_IS_OMAP4430ES1 where the > later is initialized with the former's value. I was actually wondering why the former is required > anyways. It is a redundant thing and can be replaced totally. I just rescanned the patch and now understand what you are saying. Tony's patch is fixing OMAP3 versions and Paul's patch for OMAP4. Just do the correction you mentioned for OMAP4 in Paul's patch and after testing post it. If you can test both these patches, that would be even better. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
